Do not link libgcc and stdc++ statically#17
Open
timonegk wants to merge 1 commit intoPickNikRobotics:ros2from
Open
Do not link libgcc and stdc++ statically#17timonegk wants to merge 1 commit intoPickNikRobotics:ros2from
timonegk wants to merge 1 commit intoPickNikRobotics:ros2from
Conversation
timonegk
added a commit
to bit-bots/bitbots_main
that referenced
this pull request
Feb 18, 2023
Until PickNikRobotics/bio_ik#17 is merged.
timonegk
added a commit
to bit-bots/bitbots_main
that referenced
this pull request
Feb 18, 2023
Until PickNikRobotics/bio_ik#17 is merged.
7 tasks
eholum
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
This needs a rebase over the latest ros2 branch to grab the latest API changes, but it resolves the compatibility issues with fastrtps as reported in #7.
Tried and verified in https://github.com/eholum/bio_ik_test.
@sjahr Any chance of a rebase and merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
libgccandlibstdc++are linked statically. This was added in 7cc7c10 six years ago and I don't understand why it is necessary or even helpful. For me, it now breaks stuff when bio_ik is called in a python module. You can see the code here. The errors that occur with the static linking areWith this patch applied, everything works as expected without any warnings or errors.